[Bug 230096] Review Request: iwlwifi-firmware - Microcode for Intel® PRO/Wireless 3945 A/B/G network adaptors

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: iwlwifi-firmware - Microcode for Intel® PRO/Wireless 3945 A/B/G network adaptors


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230096





------- Additional Comments From lxtnow at gmail.com  2007-02-26 22:44 EST -------
So,

MUST Fix: release tag doesn't good, from what i written above, it's your second  
          official build for extras review and and correctly set to 2 but, must 
            be followed by distag %{?dist}.
MUST Fix: License tag is invalid
          Just use "Distributable"

MUST Fix: Group tag is invalid.
          Use "System Environment/Kernel" instead of "firmware"

SHOULD Fix: BuildRoot tag doesn't quite good.
            Use 
            %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
            instead of
            %{_tmppath}/%{name}-%{version}-%{release}-root

Typo:   # This is so that the noarch packages only appears for these archs
        And what about pcc arch ?

SHOULD:  just for the form, in %build section add comment "#nothing to build"
         for a clean review.

SHOULD:  In %install section.
         use "rm -rf" instead of %{__rm} -rf.
         same thing, use "install -p -Dm 0644" instead of %{__install} -D -p -m
0644.

SHOULD Fix:  Before copy a file to the right location, you must create 
             this one by using "mkdir -p %{buildroot}%{_lib}/firmware" command.
             (even if the -D option do the same thing).

MUST Fix:  Use "%{_lib}/firmware/*.ucode" instead of "/lib/firmware/*.ucode"

MUST Fix: %changelog -> see Comment#3.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.