[Bug 221672] Review Request: php-pear-Net-POP3 - Provides a POP3 class to access POP3 server

bugzilla at redhat.com bugzilla at redhat.com
Sat Jan 13 05:32:29 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-POP3 - Provides a POP3 class to access POP3 server
Alias: pear-Net-POP3

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221672


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |kevin at tummy.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2007-01-13 00:32 EST -------
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (BSD)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
dad6200744d2c8f326fbec1f5e0c8249  Net_POP3-1.3.6.tgz
dad6200744d2c8f326fbec1f5e0c8249  Net_POP3-1.3.6.tgz.1
f2c485f9e2b306f5f75c7c71d373a26cad09667b  Net_POP3-1.3.6.tgz
f2c485f9e2b306f5f75c7c71d373a26cad09667b  Net_POP3-1.3.6.tgz.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
See below - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.  
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version

Issues:

1. I don't think that:
Requires(hint): php-pear(Net_Auth_SASL) >= 1.0
is usable with any rpm shipped by Fedora. I suppose it just makes it a hard 
Requires. Perhaps just change that to a Requires? Also, I can't seem to find 
that requirement in yet, should that package be added?

2. rpmlint says:
W: php-pear-Net-POP3 no-documentation
Which I guess can be ignored, since upstream has had no docs.

3. The
/usr/share/pear/Net
directory doesn't seem to be owned by this package,
it seems owned by php-pear-Net-FTP.
Should that package be required? or should this package also
own that directory?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list