[Bug 222670] Review Request: ksudoku - Sudoku game

bugzilla at redhat.com bugzilla at redhat.com
Tue Jan 16 20:35:56 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ksudoku - Sudoku game
Alias: ksudoku

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222670





------- Additional Comments From chris.stone at gmail.com  2007-01-16 15:35 EST -------
==== REVIEW CHECKLIST ====
- rpmlint output clean
- package named according to package naming guidelines
- spec file name matches %{name}
- meets packaging guidelines
- licensed with open source compatible license
- license matches actual license
- license included in %doc
- spec written in American english
- spec file is legible
- sources match upstream: (had to fix Source0 URL)
d5fe20e9deda671dd15340f43ab4c4a3  ksudoku-0.3.tar.gz
- successfully compiles and builds on FC-6 x86_64
- all build dependencies listed in BR
- no locales
- no shared libraries
- not relocatable
- package owns all directories it creates
- package requires other packages for directories it does not create
- no duplicates listed in %files
- file permissions set properly
- package contains proper %clean
- macro usage is consistent
- contains code
- no large documentation
- files in %doc do not affect runtime
- no header files or static libraries
- no pkgconfig files
- no .so files
- no need for devel subpackage
- no .la files
- contains proper .desktop file
- package does not own files or directories owned by other packages


==== MUST FIX ====
- Change Source0 to:
http://dl.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
- /usr/share/doc/HTML needs to be in %doc

==== SHOULD FIX ====
- Add comments above sed commands explaining what you are doing
- Add comments above the rm command for HTML/common explaining what you are doing


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list