[Bug 223618] Review Request: obexftp - Tool to access devices via the OBEX protocol
bugzilla at redhat.com
bugzilla at redhat.com
Sat Jan 20 21:42:14 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: obexftp - Tool to access devices via the OBEX protocol
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223618
tcallawa at redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
OtherBugsDependingO|163776 |163779
nThis| |
------- Additional Comments From tcallawa at redhat.com 2007-01-20 16:42 EST -------
Good:
- rpmlint checks return:
W: obexftp-python no-documentation
W: obexftp-perl no-documentation
W: obexftp-devel no-documentation
All safe to ignore.
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r
Looks good, APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list