[Bug 223068] Review Request: perl-MooseX-Object-Pluggable - Make your Moose classes pluggable

bugzilla at redhat.com bugzilla at redhat.com
Mon Jan 22 11:08:16 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-MooseX-Object-Pluggable - Make your Moose classes pluggable


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223068





------- Additional Comments From panemade at gmail.com  2007-01-22 06:08 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
b02e2baf09176b453e1b5abcde830144  MooseX-Object-Pluggable-0.0002.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'inc', 'blib/lib', 'blib/arch')" t/00-load.t t/01-basic.t t/boilerplate.t
t/pod-coverage.t t/pod.t
t/00-load.........ok 1/1# Testing MooseX::Object::Pluggable 0.0002, Perl
5.008008, /usr/bin/perl
t/00-load.........ok
t/01-basic........ok
t/boilerplate.....ok
t/pod-coverage....t/pod-coverage.t does not exist
t/pod.............ok
All tests successful.
Files=5, Tests=21,  1 wallclock secs ( 1.03 cusr +  0.05 csys =  1.08 CPU)

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list