[Bug 221372] Review Request: rb_libtorrent - A C++ BitTorrent library aiming to be the best alternative

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rb_libtorrent - A C++ BitTorrent library aiming to be the best alternative
Alias: rb_libtorrent

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221372





------- Additional Comments From peter at thecodergeek.com  2007-01-27 17:58 EST -------
I've noted the separate licenses; but AFAICT they all are very similar to the
BSD license (mostly "do what you want with the code, so long as the original
authors' copyrights are left intact and the license text is not altered")
 
> * Fedora specific documentation
>   - Please include your name.
Fixed in release 4.

> * Timestamps
>   - This package try to install many text files/image files
>     and in that case keeping on those files are preferable.
>     For this package please:
> --------------------------------------------------------
Fixed in release 4.

> * Requires, etc
>   /usr/lib/pkgconfig/libtorrent.pc includes:
> --------------------------------------------------------
> Libs: -L${libdir} -lz  -lboost_date_time -lboost_filesystem -lboost_thread -lz
> -ltorrent
> --------------------------------------------------------
>   * I doubt that addtional linkage is needed as 
Ah I see. Since we're linking against the system zlib, both the the @ZLIB@ and
@LIBS@ macros in the input file are expanded to contain '-lz' in the final
libtorrent.pc file. I've fixed this in release 4.

Spec: http:/thecodergeek.com/downloads/fedora/rb_libtorrent.spec
SRPM: http:/thecodergeek.com/downloads/fedora/rb_libtorrent-0.11-4.src.rpm

Thanks for your time and comments!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.