[Bug 199682] Review Request: postgresql-dbi-link - Partial implementation of the SQL/MED portion of the SQL:2003 specification

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postgresql-dbi-link - Partial implementation of the SQL/MED portion of the SQL:2003 specification


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199682





------- Additional Comments From kevin at tummy.com  2007-01-27 21:34 EST -------
Just to fill in some additional information here: 

- David is the upstream author of this package. (from comment #20). 
- The Oracle (and excel) dependencies were due to examples of how to use this
package, there is no real dependency on them in the package itself. 
- David is fine with Devrim maintaining the Fedora version of this package now. 
- The 2.0.0 version was released upstream, including moving those test scripts
to a 'examples' directory, and having them be shipped as doc files. 

That said, looking at the package in comment #20: 

1. You should use the %{?dist} tag: 
http://www.fedoraproject.org/wiki/Packaging/DistTag

2. You might change the 
%doc %{_datadir}/%{name}/examples
to just
%doc examples
Although I guess it's just a matter of taste where the example files are... 

I don't see anything else thats a blocker with the package in comment #20.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.