[Bug 225066] Review Request: gedit-plugins - Collections of plugins for gedit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gedit-plugins - Collections of plugins for gedit


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225066





------- Additional Comments From trond.danielsen at gmail.com  2007-01-28 11:46 EST -------
(In reply to comment #2)
> Skimming over the spec...
> 
> > %{_sysconfdir}/gconf/schemas/gedit-show-tabbar-plugin.schemas
> 
> Scriptlets for gconftool install/uninstall of these schemas
> is missing: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
> 

Fixed.

> > %{_datadir}/locale/*
> 
> Use the %find_lang macro appropriately instead of including the
> files like this. This is a MUST item according to the guidelines.
> 

Fixed.

> > %doc README INSTALL NEWS AUTHORS COPYING
> 
> The 'INSTALL' file most likely is the standard "Basic Installation"
> document which is irrelevant to RPM package users.
> 

INSTALL file removed.

> > Summary:        Gedit-plugins is a collection of plugins for gedit
> 
> Repeating the package name in the summary is commonly considered
> bad taste. Better and short to the point:
> 
> Summary: Plug-ins for gEdit
> 
> Or:
> 
> Summary: plug-in collection for gEdit

Fixed.

Thanks for the quick reply. I have uploaded the new and improved versions to the
same location as previously (ftp://open-gnss.org/pub/fedora)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.