[Bug 236486] Review Request: Profugus - automatically migrates Xen virtual machines from one system to another based on CPU time

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Profugus - automatically migrates Xen virtual machines from one system to another based on CPU time


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236486





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-07-02 03:32 EST -------
Actually I have only one machine :) However now I can trust you.

By the first glance at 0.2-2:
For packaging of 0.2-2, some issues must be fixed.

* Version
  - On rpm packaging, "0.2-2" is considered as Version (as hyphen is
    not allowed for rpm version, for this case the rpm version is 0.2.2)
    So the EVR (Epoch:Version:Release) is
    0.2.2-<number>%{?dist}.
* Descriptsion
  - contains too long line (must not exceed 79 characters)
* Arch
  - This package contains only text files and architecture must be
    noarch.
* Macros
  - Please use macros (please check %_sysconfdir, %_mandir,
    %_initrddir for example)
* scripts
---------------------------------------------------
mkdir -p %{buildroot}/etc/rc.d/rc3.d %{buildroot}/etc/rc.d/rc5.d/
---------------------------------------------------
  - Why is this needed?
* Permission
  - The permissions of the following files are incorrect.
-----------------------------------------------------
E: profugus script-without-shebang /etc/profugus.conf
W: profugus spurious-executable-perm /usr/share/man/man8/profugus.8.gz
-----------------------------------------------------
* File entry
  - /etc/profugus.conf is listed twice.
* Requires
  - Add proper %Requires(post), etc (check: "Services" subsection of
    http://fedoraproject.org/wiki/Packaging/ScriptletSnippets )
* defattr
  Now we recommend: %defattr(-,root,root,-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.