[Bug 246525] Review Request: mini - A high-performance terrain rendering library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mini - A high-performance terrain rendering library
Alias: mini

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246525





------- Additional Comments From kwizart at gmail.com  2007-07-03 06:26 EST -------
Ok fine!
Actually there is two remaining things.
- It is usually better to have a full license text (not in html) in the main
package. If you have contacted upstream about your patch, I would suggest that
you submit also a COPYING file from the full LGPL license...so that could be
bundled in the main package.
- Mini.pc could be renamed libMini.pc (so library, pc file and package name are
the same). Mini.pc can be allowed also anyway...
Usually you should split libs that are required by your package at runtime from
libs that package that link to the -lMini needs (Requires: field instead of
Libs: field).
See man pkg-config... Anyway since not all Required libs are pkgconfig
compatible  (mesa's are not it seems), you could add Requires: xmu xt x11 (or
only xmu since it already return -lXmu -lXt -lX11 ). Those will be returned also
when using pkg-config --libs Mini (or libMini), then leave mesa from the Libs field.
About /usr/include/X11, you can leave it empty as /usr/include is used and this
is the default (x11.pc don't writte it for a sample).

Since all autotools are patched, i would suggest that upstream include your
patch first. So if for any reason, upstream decide to uses cmake, the tweaks
will be differents.. (well that would be a shame, since you've done all the work
well...)

I will review others packages to have a better overview of them...



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.