[Bug 246524] Review Request: libquikgrid - The QuikGrid generator and contouring routine library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libquikgrid -  The QuikGrid generator and contouring routine library
Alias: libquikgrid

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246524





------- Additional Comments From kwizart at gmail.com  2007-07-03 07:49 EST -------
from spec file:
mv lesser.txt LICENSE
you should better use this. That will prevent timestramp  (install used as a
better cp )
install -pm 0644 lesser.txt LICENSE
Also i wonder if this:
"Permission to copy for non commercial purposes is granted provided the source
is acknowledged." is allowded by LGPL as this suggest that commercial
distribution (like RHEL), is not allowed to redistribute it freely...?!
Also this http://www.perspectiveedge.com/disclaimer.html disagree with the LGPL
license. (Does this page plan be updated ?)

Does this license change have been made recently ?
Upstream suggest that 5.3 is avaible but only 0.4 source is downloadable...

You should usually not uses %{version} for patch (unless changes are made for
the patch between each version) This will prevent to uses cvs history for the
file... For that, that would be better to merge your patch upstream also...

>From build.log:
ckward_warning.h:32:2: warning: #warning This file includes at least one depreca
ted or antiquated header. Please consider using one of the 32 headers found in s
ection 17.4.1.2 of the C++ standard. Examples include substituting the <X> heade
r for the <X.h> header for C++ includes, or <iostream> instead of the deprecated
 header <iostream.h>. To disable this warning use -Wno-deprecated.
 -> This should be reported upstream (only warnings anyway)

That would be better that archive name follow the name package, i don't knwo if
upstream will change it also. I think that you set the right package name...

sum-up:
License in unclear
Merge autotools patch upstream (with the license in the main package)



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.