[Bug 246460] Review request: qtpfsgui - A Qt4 graphical user interface that provides a workflow for HDR imaging

bugzilla at redhat.com bugzilla at redhat.com
Tue Jul 3 23:15:09 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review request: qtpfsgui - A Qt4 graphical user interface that provides a workflow for HDR imaging


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246460


bruno at postle.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bruno at postle.net




------- Additional Comments From bruno at postle.net  2007-07-03 19:15 EST -------
Looks good to me, I was going to submit this myself.  My suggestions, though you
don't have to follow them:

The summary could be a bit less cryptic:

  A graphical tool for creating and tone-mapping HDR images

..and the description should say a bit more:

  Qtpfsgui is a graphical program for assembling bracketed photos into High
  Dynamic Range (HDR) images.  It also provides a number of tone-mapping
  operators for creating low dynamic range versions of HDR images.

I would fix the newlines in %prep and not %install, but this isn't important.

You can call 'desktop-file-install' with '--delete-original', then you don't
have to manually delete it afterwards

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list