[Bug 245103] Review Request: php-spyc- A simple php yaml class

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-spyc- A simple php yaml class


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245103


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-07-03 21:40 EST -------
Builds OK, rpmlint is quiet and everything looks good to me.  There's really not
much at all to this package.

Terribly minor: there's a stray leading space on the last line of the %description.

Note that this is a plain PHP package, not a PEAR package.

Review:
* source files match upstream:
   8598d8dbc77b79743c633345cfe47c2e8adbb8eff0d44b2d52401150dc056a3b  
   spyc-0.2.5.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   php-spyc = 0.2.5-1.fc8
  =
   php
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.