[Bug 243716] Review Request: perl-Text-Markdown - A text-to-HTML filter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Text-Markdown - A text-to-HTML filter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243716


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-07-03 23:09 EST -------
Still need to s/GPL/BSD/ on the License: tag.

I'm OK with the skipped tests; it's OK to keep the additional build dependencies
because once the docs are complete upstream will probably enable them by
default.  If you want to set TEST_POD and delete t/03podcoverage.t then go
ahead; I'll leave that up to you.

So there's just the license tag, which is of significant importance but is
trivial to fix.  I'll go ahead and approve this and you can fix it when you
check in.

Review:
* source files match upstream:
   1191bb1a1ba0268a8d940dcc10c767ac68e18bc5fe4cc38f559210d4c62c35b3  
   Text-Markdown-1.0.3.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
X license field matches the actual license.
* license is open source-compatible.
* license text included in package (in the README file).
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Text::Markdown) = 1.0.3
   perl-Text-Markdown = 1.0.3-2.fc8
  =
   perl >= 0:5.006_000
   perl(:MODULE_COMPAT_5.8.8)
   perl(Digest::MD5)
   perl(base)
   perl(strict)
   perl(warnings)
* %check is present and all tests pass:
   All tests successful, 2 tests skipped.
   Files=4, Tests=4,  0 wallclock secs ( 0.33 cusr +  0.11 csys =  0.44 CPU)
  The skipped tests are just documentation tests.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED, just fix the License: tag.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.