[Bug 226539] Merge Review: which

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: which


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226539





------- Additional Comments From ruben at rubenkerkhof.com  2007-07-05 14:02 EST -------
Review for release 9:
* RPM name is OK
* Source which-2.16.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* File list looks OK

Rpmlint is not clean.

Source RPM:
W: which strange-permission which-2.csh 0775
W: which strange-permission which-2.sh 0775

0644 will do just fine, the files are sourced.

rpmlint of which:
E: which executable-marked-as-config-file /etc/profile.d/which-2.csh
E: which executable-sourced-script /etc/profile.d/which-2.csh 0755
E: which executable-marked-as-config-file /etc/profile.d/which-2.sh
E: which executable-sourced-script /etc/profile.d/which-2.sh 0755

Solved quite easy by setting permissions to 0644

W: which incoherent-version-in-changelog 2.16-9.fc7 2.16-9.fc8

Don't use the disttag in the changelog

W: which conffile-without-noreplace-flag /etc/profile.d/which-2.csh
W: which conffile-without-noreplace-flag /etc/profile.d/which-2.sh

Use %config(noreplace) in your file section

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.