[Bug 247227] Review Request: Nabi - hangul and hanja X input method

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Nabi - hangul and hanja X input method


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-07-06 07:21 EST -------
Well, you may want to check the spec files of other packages.
For example, there is scim spec:
http://cvs.fedoraproject.org/viewcvs/*checkout*/rpms/scim/devel/scim.spec

Please check the packaging guidelines:
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

* SourceURL must be given with full URL.
* Don't rebuild in mock. At least, libhangul-devel is missing for
  BuildRequires
* Fedora specific compilation flags are not honored. Perhaps
  this can be resolved by using %configure macro.
* Please support parallel make when possible.
* "install-strip" is forbidden. This disables to create debuginfo
  rpm.
* Please keep timestamps. When using "install" command, use it
  with '-p' option.
* Use macros (e.g. /usr/share -> %{_datadir})
* Categories 'Application' 'X-Red-Hat-Base' are deprecated and
  should be removed
* desktop file must be installed by using desktop-file-install
  (BR: desktop-file-utils is needed)
* The binaries which are not under normal users' paths must be
  specified with full path.
* gettext .mo files must be registered in %files entry by using
  %find_lang macro.
* files under %_sysconfdir should be marked as %config(noreplace)
* We recommend %defattr(-,root,root,-)
* Please remove unused macros.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.