[Bug 247273] Review Request: coco-coq - An AGI Adventure game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: coco-coq - An AGI Adventure game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247273





------- Additional Comments From tibbs at math.uh.edu  2007-07-06 12:44 EST -------
Builds fine; rpmlint is clean.

The URL is 404 for me.  It looks like a typo; should probably be
http://membres.lycos.fr/agisite/coco-c.htm

Are you sure you removed something from the included zipfile?  It has the same
size and same contents as the upstream file.

Aside from those, this package is is OK.  Unfortunately I can't approve it as is
 because of the upstream zipfile issue.

? source files match upstream, but I don't think they're supposed to.
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is acceptable for content.
* license text not included upstream, but communications with the author 
   clarifying the license are included.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   coco-coq = 0.1-1.fc8
  =
   /bin/bash
   /bin/sh
   hicolor-icon-theme
   nagi
* %check is not present; no test suite upstream.  I tested manually (and 
   promptly fell off a cliff); everything seems to work fine.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* acceptable content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* GUI app; desktop file installs cleanly and looks OK.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.