[Bug 238994] Review Request: memcached - High Performance, Distributed Memory Object Cache

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: memcached - High Performance, Distributed Memory Object Cache


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238994





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-07-07 03:09 EST -------
For 1.2.3-1: Almost okay.

* Timestamps
  - To keep timestamp on man file, please use the following.
-----------------------------------------------------------
make install DESTDIR=%{buildroot} INSTALL="%{__install} -p"
-----------------------------------------------------------

* Changelog
  - rpm EVR is 1.2.3-1, however the last entry of %changelog
    is 1.2.2-5.

! (Request: NOT a blocker)
  - Initscripts
    We (including me) are now required to fix initscripts
    to match LSB requirement. Check:
    http://fedoraproject.org/wiki/FCNewInit/Initscripts
    For now, I found:
    * force-reload option is missing
    * starting memcached whe memcached is already running
      fails:
-----------------------------------------------------------
[root at localhost ~]# LANG=C service memcached start ; echo $?
Starting memcached:                                        [  OK  ]
0
[root at localhost ~]# LANG=C service memcached status ; echo $?
memcached (pid 5742) is running...
0
[root at localhost ~]# LANG=C service memcached start ; echo $?
Starting memcached: bind(): Address already in use
failed to listen
                                                           [FAILED]
1
------------------------------------------------------------
    * Non-impremented option returns 1, not 3 (well, I guess
      most of current initscripts return 1 for now...)
------------------------------------------------------------
[root at localhost ~]# LANG=C service memcached foo ; echo $?
Usage: /etc/init.d/memcached {start|stop|status|restart|reload|condrestart}
1
------------------------------------------------------------
     Please fix above, for example (but I WON'T treat these
     as a blocker).

And.. as this is NEEDSPONSOR ticket, I rewrite for confirmation:
-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on:
http://fedoraproject.org/PackageReviewStatus/NEW.html
(NOTE: please don't choose "Merge Review")


Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.