[Bug 241279] Review Request: avr-libc - C library for use with GCC on Atmel AVR microcontrollers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: avr-libc - C library for use with GCC on Atmel AVR microcontrollers


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241279


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |trond.danielsen at gmail.com




------- Additional Comments From j.w.r.degoede at hhs.nl  2007-07-08 02:44 EST -------
(In reply to comment #4)
> Some remarks:
> 
> * I'd recommend to let the *-docs package put its doc files into
> /usr/share/doc/avr-libc-%version
> 

I'm afraid thats impossible, as rpmbuild erases that dir before checking %files:
Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.46262
+ umask 022
+ cd /home/hans/projects/fedora-extras/wip/avr-libc
+ cd avr-libc-1.4.6
+ DOCDIR=/var/tmp/avr-libc-1.4.6-3.fc8-hans/usr/share/doc/avr-libc-1.4.6
+ export DOCDIR
+ rm -rf /var/tmp/avr-libc-1.4.6-3.fc8-hans/usr/share/doc/avr-libc-1.4.6
+ /bin/mkdir -p /var/tmp/avr-libc-1.4.6-3.fc8-hans/usr/share/doc/avr-libc-1.4.6

So writing "%doc /usr/share/doc/avr-libc-docs-1.4.6/foo" won't work because if
foo was installed there it will be erased. And using %doc foo, will make it end
up as /usr/share/doc/avr-libc-docs-1.4.6/foo

> * I don't think shipping the man pages in /usr/share/doc/avr-libc-%version/man
> is a good idea. It will break avr-man when installing the rpm w/ --exclude-docs
> 
> I'd put them somewhere else, e.g. /usr/share/avr-libc, /usr/avr/share/man or
> even /usr/avr/sys-root/usr/share/man. I'd use /usr/avr/share/man.
> 

Here is a new version which moves the manpages to /usr/avr/share/man, Trond any
chance you could review this?

Spec URL: http://people.atrpms.net/~hdegoede/avr-libc.spec
SRPM URL: http://people.atrpms.net/~hdegoede/avr-libc-1.4.6-3.fc8.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.