[Bug 247482] Review Request: pwsafe - A unix command line utility that manages encrypted password databases

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pwsafe - A unix command line utility that manages encrypted password databases


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247482


jochen at herr-schmitt.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|wtogami at redhat.com          |jochen at herr-schmitt.de
               Flag|                            |fedora-review?




------- Additional Comments From jochen at herr-schmitt.de  2007-07-09 14:01 EST -------
Good:
+ Packing Naming is ok.
+ Name of the SPEC File matches the package name
+ Package hast consitant macor usage.
+ Packsge contains %{?dist} tag
+ SPEC start to use GPL as an license
+ License is an open source license
+ License Tag matches with license test in the package
+ Package contains verbatim copy of the license text
+ Spec file is written in English
+ Tar ball matches with upstream
  (md5sum: 4bb36538a2772ecbf1a542bc7d4746c0)
+ Package has correct buildroot
+ package doesn't contains subpackages.
+ Buildroot will cleaned on %clean section an on the beginning of the %install
section
+ Package conatins proper* %defattr and file permissions
+ %doc section is small
* %doc section doen't affect runtime
+ Package doesn't contains duplicates file in the %file section
+ Package doesn't contains files or directories owned by ohter packages
+ Local build works fine
+ Rpmlint quite on Source rpm.
+ Rpmlint quite on Debuginfo rpm.
+ Local install and uninstall works fine
+ Mock build works fine for Devel and F-7 (x86_64, i386, PPC64, PPC)

Bad:
- Rpmlint has complaints for the binary package:
pmlint pwsafe-0.2.0-0.1.fc7.x86_64.rpm
W: pwsafe file-not-utf8 /usr/share/man/man1/pwsafe.1.gz
W: pwsafe incoherent-version-in-changelog 0.2.0-0.1.fc8 0.2.0-0.1.fc7
- When I call 'pwsafe --createdb' I will got the following message:
WARNING: pwsafe unable to use secure ram (need to be setuid root)











-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.