[Bug 229419] Review Request: glew - The OpenGL Extension Wrangler Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glew - The OpenGL Extension Wrangler Library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229419


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora




------- Additional Comments From bruno at postle.net  2007-07-09 17:28 EST -------
(In reply to comment #10)
> 
> - Provides: libglew-devel = %{version}-%{release}
> Why do you need this ?

No good reason I can think of, gone.

> - CFLAGS="-Iinclude $RPM_OPT_FLAGS"
> This will replace -Iinclude indeed - so you may need to have this in %prep (to
> prevent CFLAGS replacement)
> sed -i -e 's|$(POPT)|%{optflags}|' Makefile

I can't remember how the CFLAGS got in there in the first place, your fix seems
to work, applied.

> - Prefer to use this at %prep (if possible for the doc generated before make)
> sed -i 's/\r//' README.txt doc/* 

Heh, I just advised the same to someone else in a different review.  It isn't
necessary anymore, gone.

> - doc sub-package isn't really big, you may consider to merge it with the -devel

I'm not sure what the criteria is for splitting or not.  As HTML documentation,
it really ought to require a web-browser..  Left as separate for now.

> - make should uses %{?_smp_mflags} (it seems to work)

Done.

> W: glew unused-direct-shlib-dependency

Don't know what to do about this, I added the extra BuildRequires anyway.

> - Shouldn't we block FE-LEGAL for the sgi problem or is this clear enought for
> you ?

It seems that if it is ok for debian then it ought to be ok for fedora.  I'll
block FE-LEGAL if it is necessary to bring it to attention?

> rpmlint complain about W: glew invalid-license Assorted licenses,

See previous comment, according to the debian document the license would be
something like "BSD + GPL"

Updated package:

http://bugbear.blackfish.org.uk/~bruno/apt/fedora/linux/7/x86_64/SRPMS.panorama/glew-1.4.0-2.fc7.src.rpm
http://bugbear.blackfish.org.uk/~bruno/apt/SPECS/glew.spec


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.