[Bug 234612] Review Request: Ice - The Internet Communications Engine (Object middleware)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Ice - The Internet Communications Engine (Object middleware)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234612





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-07-10 10:56 EST -------
Again I just checked for packaging.

For 3.2.0-5:

0. Description stage:
* Macros
  - %_sbindir is /usr/sbin, where service (and so on) is
    under /sbin, not under %_sbindir (there is no macro which
    corresponds with /sbin).
    Same for scriptlets.

* php Requirement
  - -php subpackage has "Requires: php >= 5.1.4". Does this mean
    that BuildRequires for php dependency should also have version
    specific dependency, i.e. "BuildRequires: php >= <someversion>"?

1. %build stage
* %optflags
  - %optflags is still not honored completely.
------------------------------------------------------
make[2]: Leaving directory `/builddir/build/BUILD/Ice-3.2.0/src/IceUtil'
making all in icecpp
make[2]: Entering directory `/builddir/build/BUILD/Ice-3.2.0/src/icecpp'
cc -c -I../../include  -O2 -I. -DPREFIX=\"\" cccp.c
cc -c -I../../include  -O2 -I. -DPREFIX=\"\" cexp.c
cc -c -I../../include  -O2 -I. -DPREFIX=\"\" prefix.c
rm -f ../../bin/icecpp
cc -O2 -I. -DPREFIX=\"\" -o ../../bin/icecpp cccp.o cexp.o prefix.o
make[2]: Leaving directory `/builddir/build/BUILD/Ice-3.2.0/src/icecpp'
------------------------------------------------------

2. Scripts
* Home directory
  - It seems that no one owns %_localstatedir/lib/icegrid, or
    doesn't this directory needed?

3. Others
* rpmlint
------------------------------------------------------
W: ice macro-in-%changelog _libdir (etc)
------------------------------------------------------
  - In %changelog, please use %%_prefix, %%_libdir, ...
    so that macros won't be expanded.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.