[Bug 247615] Review Request: TECkit - Conversion library and mapping compiler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: TECkit - Conversion library and mapping compiler


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247615


jochen at herr-schmitt.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |jochen at herr-schmitt.de
               Flag|                            |fedora-review?




------- Additional Comments From jochen at herr-schmitt.de  2007-07-10 12:08 EST -------
Good:
+ Package name meets naming guidelines
+ Name of SPEC file matches with package name.
+ SPEC file consitant macro usage.
+ SPEC file contains %{?dist} macro
+ License is LGPL
+ Package has the choice to use CPL or LGPL
+ SPEC in English
+ SPEC is legible
+ Sub packages are declared properly
+ Tar ball matches with upstream
  (md5sum: 6b7538aa53aa844db8bb95c1219d62d1)
+ Package has correct buildroot
+ BuildRequires isn't redundant
+ Local build works properly
+ Package contains proper %defattr and file permissions
+ Package has a proper clean section
+ Buildroot will be cleand in %clean section and on the beginning of the
%install section
+ Package and sub packages doc files don't affect runtine
+ File size on the %doc section is acceptable
+ Package doesn't contains static libraries
+ Package file list doesn't contains duplicates files
+ Package contains no files or directories owned by other packages


Bad:
- %{_smp_mflags] wasn't used during make step.
Pleae add it or add a comment which described, that the build doesn't works
with it
- Package doesn't contains verbatim copy of the license
  The file COPYING refers to a text file which is not included in the package
- Rpmlint complaints on source rpm:
rpmlint -i teckit-2.2.1-0.1.fc7.src.rpm
E: teckit configure-without-libdir-spec
Because package use %configure macro, this may be ignored
- Package contains zero length file 
rpmlint teckit-2.2.1-0.1.fc7.x86_64.rpm
E: teckit zero-length /usr/share/doc/teckit-2.2.1/ChangeLog
- Rpmlint complaints on installed package:
rpmlint teckit
E: teckit zero-length /usr/share/doc/teckit-2.2.1/ChangeLog
W: teckit unused-direct-shlib-dependency /usr/lib64/libTECkit_Compiler.so.0.0.0
/lib64/libexpat.so.0
W: teckit unused-direct-shlib-dependency /usr/lib64/libTECkit_Compiler.so.0.0.0
/lib64/libm.so.6
W: teckit unused-direct-shlib-dependency /usr/lib64/libTECkit.so.0.0.0
/lib64/libexpat.so.0
W: teckit unused-direct-shlib-dependency /usr/lib64/libTECkit.so.0.0.0
/lib64/libm.so.6
- Mock build fails:
*** Recreating libtool files
libtoolize
./autogen.sh: line 7: libtoolize: command not found
*** Recreating aclocal.m4
aclocal
./autogen.sh: line 12: aclocal: command not found
*** Recreating configure
./autogen.sh: line 17: autoheader: command not found
./autogen.sh: line 18: autoconf: command not found
*** Recreating the Makefile.in files
./autogen.sh: line 22: automake: command not found

You have to define the require automake/autoconf tools as BRs.

Optimizing Hints:

If a entry in the %file section and with a slash, all files and directories
beyond it will be included into the package, so you may write

%{_includedir}/teckit/

instead of

%dir %{_includedir}/teckit/
%{_includedir}/teckit/TECkit_Common.h
%{_includedir}/teckit/TECkit_Compiler.h
%{_includedir}/teckit/TECkit_Engine.h



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.