[Bug 243665] Review Request: perl-Geo-IP - Efficient GeoIP bindings for Perl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Geo-IP - Efficient GeoIP bindings for Perl


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243665





------- Additional Comments From tibbs at math.uh.edu  2007-07-10 12:54 EST -------
Unfortunately the test suite fails for me because it tries to look up yahoo.com,
but mock does not run with a configured DNS server.  I inserted
   perl -pi -e 's/yahoo.com.*//' t/2_namelookup.t
before the "make test" line and it runs to completion.  I guess the test count
should be off but it doesn't seem to bother anything.  You could also just
delete t/2_namelookup.t.

Please make consistent use of macros; don't use both "%{__perl}" and "perl",
just pick one.  But if you want to pick the macro-ized version, you need to use
the macroized versions of rm, make, chmod, etc. as well.

You don't need the manual dependency on GeoIP; rpm finds the libGeoIP dependency
on its own.

Review:
* source files match upstream:
   bede8433e200a433cc0defd198136d5d6dd0580542a92f516a707f4829db0c52  
   Geo-IP-1.28.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
X specfile does not use macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
? final provides and requires; see extraneous GeoIP dependency.
   IP.so()(64bit)
   perl(Geo::IP) = 1.28
   perl(Geo::IP::Record)
   perl(Geo::Mirror) = 1.0
   perl-Geo-IP = 1.28-1.fc8
  =
?  GeoIP
   libGeoIP.so.1()(64bit)
   perl(:MODULE_COMPAT_5.8.8)
   perl(Geo::IP::Record)
   perl(base)
   perl(constant)
   perl(strict)
   perl(vars)

X %check is present, but test fail in mock due to missing DNS services:
   t/2_namelookup....
   # Test 11 got: <UNDEF> (t/2_namelookup.t at line 18 fail #11)
   #    Expected: "US"
   #  t/2_namelookup.t line 18 is:   ok($country, $exp_country);
   FAILED test 11
        Failed 1/11 tests, 90.91% okay
   t/3_mirror........ok
   Failed Test      Stat Wstat Total Fail  Failed  List of Failed
   -----------------------------------------------------------------------------
   t/2_namelookup.t               11    1   9.09%  11
   Failed 1/4 test scripts, 75.00% okay. 1/33 subtests failed, 96.97% okay.

* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.