[Bug 217197] Review Request: MyBashBurn - burn data and songs.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: MyBashBurn - burn data and songs.
Alias: MyBashBurn

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217197





------- Additional Comments From tibbs at math.uh.edu  2007-07-10 20:30 EST -------
OK, this builds and installs fine in mock on x86_64 running rawhide.  rpmlint says:
  W: mybashburn spurious-executable-perm /usr/share/man/man1/mybashburn.1.gz
which is easily fixed by setting the permissions to 644 when you install it.

Unfortunately when I attempted to test this, all I get is a message flashingg by
telling me "Terminal size must be fix, the size now is 80x24 Fai MyBashBurn
1.0.2" and then the program exits.  This is on an i386 machine running rawhide.

You need to be consistent about your macro usage.  If you want to use the
macroized forms like %{__sed} then you need to use %{__rm}, %{__install},
%{__cp} and %{__ln}.

Don't start the summary with the name of the package.

You install CREDITS and HOWTO twice.  If they're required as internal help
files, they shouldn't also be installed as %doc.

Review:
* source files match upstream:
   058395728c295988c3d633f5a2a25224f25babea6117d4b35c26c7b7b93e0d6a  
   mybashburn-1.0.2.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named
X specfile does not use macros consistently.
X summary should not start with the name of the package.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
X rpmlint has a valid complaint.
* final provides and requires are sane:
   mybashburn = 1.0.2-1.fc8
  =
   /bin/sh
   /usr/bin/env
   cdda2wav
   cdrdao
   cdrecord
   coreutils
   dialog >= 1.0
   dvd+rw-tools
   eject
   flac
   mkisofs
   vorbis-tools
* %check is not present; no test suite upstream.
X Manual testing was not at all successful.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
X CREDITS and and HOWTO are duplicated.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.