[Bug 247642] Review Request: perl-Net-DNS-Resolver-Programmable - Programmable DNS resolver class for offline emulation of DNS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-DNS-Resolver-Programmable - Programmable DNS resolver class for offline emulation of DNS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247642


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-07-10 21:04 EST -------
Not much to say.

* source files match upstream:
   8d402260941f259c83bf1b2564408e75288df028f604136c29da11a9a6a076ec  
   Net-DNS-Resolver-Programmable-v0.003.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Net::DNS::Resolver::Programmable)
   perl-Net-DNS-Resolver-Programmable = 0.003-1.fc8
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Net::DNS::Packet)
   perl(base)
   perl(constant)
   perl(strict)
   perl(version)
   perl(warnings)
* %check is present, but there aren't any tests to run.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.