[Bug 246539] Review Request: R-BufferedMatrix - A matrix data storage object held in temporary files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: R-BufferedMatrix - A matrix data storage object held in temporary files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246539


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2007-07-11 14:48 EST -------
Normally I don't care at all about Group:, but I do wonder why you think
Applications/Productivity is appropriate

The -devel package must have a dependency on the non-devel package.

The manual R dependency unnecessary for arch-specific R packages, but I don't
think it's a blocker.

You are missing some %doc directories.  These are all listed out in the template.

You don't own the top-level directory of the package.  This, too, is listed in
the template.

Review:
* source files match upstream:
   452483454bf11c7d6484164776feccb26e10597df78a9eb7dd8111c209f88af3  
   BufferedMatrix_1.0.1.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
X final provides and requires:
  R-BufferedMatrix-1.0.1-4.fc8.x86_64.rpm
   BufferedMatrix.so()(64bit)
   R-BufferedMatrix = 1.0.1-4.fc8
  =
   /bin/sh
   R
   libR.so()(64bit)

  R-BufferedMatrix-devel-1.0.1-4.fc8.x86_64.rpm
   R-BufferedMatrix-devel = 1.0.1-4.fc8
  =
X (no dependencies)

* %check is present and all tests pass:
  checking tests ...
    Running 'Rcodetesting.R'
    Running 'c_code_level_tests.R'
    Running 'objectTesting.R'
    Running 'rawCalltesting.R'
  OK

* no shared libraries are added to the regular linker search paths.
X doesn't own ..R/library/BufferedMatrix
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets OK (R index creation)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel subpackage.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.