[Bug 247705] Review Request: perl-Mail-SPF - Object-oriented implementation of Sender Policy Framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Mail-SPF - Object-oriented implementation of Sender Policy Framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247705


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-07-11 15:05 EST -------
Another clean Perl module....

* source files match upstream:
   b8ffb09c538bf4fe3b79ff45dad942879fec9c975a08243c0a59ab3e92439b8a  
   Mail-SPF-v2.005.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Mail::SPF)
   perl(Mail::SPF::Base)
   perl(Mail::SPF::EAbstractClass)
   perl(Mail::SPF::EClassMethod)
   perl(Mail::SPF::EDNSError)
   perl(Mail::SPF::EDNSTimeout)
   perl(Mail::SPF::EDuplicateGlobalMod)
   perl(Mail::SPF::EInstanceMethod)
   perl(Mail::SPF::EInvalidMacro)
   perl(Mail::SPF::EInvalidMacroString)
   perl(Mail::SPF::EInvalidMech)
   perl(Mail::SPF::EInvalidMechQualifier)
   perl(Mail::SPF::EInvalidMod)
   perl(Mail::SPF::EInvalidOptionValue)
   perl(Mail::SPF::EInvalidRecordVersion)
   perl(Mail::SPF::EInvalidScope)
   perl(Mail::SPF::EInvalidTerm)
   perl(Mail::SPF::EJunkInRecord)
   perl(Mail::SPF::EJunkInTerm)
   perl(Mail::SPF::EMacroExpansionCtxRequired)
   perl(Mail::SPF::ENoAcceptableRecord)
   perl(Mail::SPF::ENoUnparsedText)
   perl(Mail::SPF::ENothingToParse)
   perl(Mail::SPF::EOptionRequired)
   perl(Mail::SPF::EProcessingLimitExceeded)
   perl(Mail::SPF::EReadOnlyValue)
   perl(Mail::SPF::ERecordSelectionError)
   perl(Mail::SPF::ERedundantAcceptableRecords)
   perl(Mail::SPF::ESyntaxError)
   perl(Mail::SPF::ETermDomainSpecExpected)
   perl(Mail::SPF::ETermIPv4AddressExpected)
   perl(Mail::SPF::ETermIPv4PrefixLengthExpected)
   perl(Mail::SPF::ETermIPv6AddressExpected)
   perl(Mail::SPF::ETermIPv6PrefixLengthExpected)
   perl(Mail::SPF::EUnexpectedTermObject)
   perl(Mail::SPF::Exception)
   perl(Mail::SPF::GlobalMod)
   perl(Mail::SPF::MacroString)
   perl(Mail::SPF::Mech)
   perl(Mail::SPF::Mech::A)
   perl(Mail::SPF::Mech::All)
   perl(Mail::SPF::Mech::Exists)
   perl(Mail::SPF::Mech::IP4)
   perl(Mail::SPF::Mech::IP6)
   perl(Mail::SPF::Mech::Include)
   perl(Mail::SPF::Mech::MX)
   perl(Mail::SPF::Mech::PTR)
   perl(Mail::SPF::Mod)
   perl(Mail::SPF::Mod::Exp)
   perl(Mail::SPF::Mod::Redirect)
   perl(Mail::SPF::PositionalMod)
   perl(Mail::SPF::Record)
   perl(Mail::SPF::Request)
   perl(Mail::SPF::Result)
   perl(Mail::SPF::Result::Error)
   perl(Mail::SPF::Result::Fail)
   perl(Mail::SPF::Result::Neutral)
   perl(Mail::SPF::Result::NeutralByDefault)
   perl(Mail::SPF::Result::None)
   perl(Mail::SPF::Result::Pass)
   perl(Mail::SPF::Result::PermError)
   perl(Mail::SPF::Result::SoftFail)
   perl(Mail::SPF::Result::TempError)
   perl(Mail::SPF::SenderIPAddrMech)
   perl(Mail::SPF::Server)
   perl(Mail::SPF::Term)
   perl(Mail::SPF::UnknownMod)
   perl(Mail::SPF::Util)
   perl(Mail::SPF::v1::Record)
   perl(Mail::SPF::v2::Record)
   perl-Mail-SPF = 2.005-1.fc8
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Error)
   perl(Mail::SPF::Exception)
   perl(Mail::SPF::MacroString)
   perl(Mail::SPF::Mod)
   perl(Mail::SPF::Record)
   perl(Mail::SPF::Request)
   perl(Mail::SPF::Result)
   perl(Mail::SPF::Server)
   perl(Mail::SPF::Util)
   perl(Net::DNS) >= 0.58
   perl(Net::DNS::Resolver)
   perl(NetAddr::IP)
   perl(Sys::Hostname)
   perl(URI) >= 1.13
   perl(URI::Escape)
   perl(base)
   perl(constant)
   perl(strict)
   perl(utf8)
   perl(version)
   perl(warnings)
* %check is present and all tests pass:
   t/00.00-class-misc............ok
   t/00.01-class-util............ok
   t/00.02-class-request.........ok
   t/00.03-class-result..........ok
   t/00.04-class-server..........ok
   t/00.05-class-macrostring.....ok
   t/00.99-class-misc............ok
   t/10.00-rfc4408...............skipped
        all skipped: Mail::SPF::Test required for testing Mail::SPF's RFC compliance
   t/10.01-rfc4406...............skipped
        all skipped: Mail::SPF::Test required for testing Mail::SPF's RFC compliance
   t/90-author-pod-validation....ok
   All tests successful, 2 tests skipped.
   Files=10, Tests=155, 142 wallclock secs ( 1.55 cusr +  0.32 csys =  1.87 CPU)
   (Skipped tests require a module not yet in Fedora)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.