[Bug 246138] Review Request: eclipse-QuickREx - QuickREx is a regular-expression test Eclipse Plug-In

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-QuickREx - QuickREx is a regular-expression test Eclipse Plug-In


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246138





------- Additional Comments From alcapcom at gmail.com  2007-07-11 17:52 EST -------
SPEC: http://download.tuxfamily.org/borsalino/7/SPECS/eclipse-quickrex.spec
SRPMS
http://download.tuxfamily.org/borsalino/7/SRPMS/eclipse-quickrex-3.5.0-3.fc7.src.rpm

(In reply to comment #8)
> MUST:
> ? package is named appropriately
>  - can we get confirmation from upstream about the capitalization issue?
>    I just don't want to go against their wishes.  Otherwise, it's fine.
Have just send a mail to Bastian (upstream guy), normally that should be ok.

> X verify source and patches (md5sum matches upstream, know what the patches do)
>  - while I can't verify the md5sum of your tarball, I don't get any
>    differences on a diff of the exploded tarball so I think we're fine.
>    The instructions are also clear.
>  - my only concern is the build.properties and feature.xml files -- did
>    upstream author these or did you?  can they not be included upstream?
>    I thought package-build worked fine with packages that didn't have
>    features - does it not?  I guess I just want to know what the purpose
>    of these files is and whether or not they will go upstream at some
>    point :) .
I have send both to Bastian and he should include a feature for the next
release, so I have fake it for the moment.

> X rpmlint on <this package>.srpm gives no output
>  $ rpmlint ../SRPMS/eclipse-quickrex-3.5.0-2.fc7.src.rpm 
>  eclipse-quickrex.src:145: W: strange-permission fetch-quickrex.sh 0764
> 
>  Can we make it 0755 or something?
fixed
 
> X changelog fine except for extra space in first line:
>   * Thu Jul 5 2007 Alphonse Van Assche  <alcapcom at gmail.com> 3.5.0-2
fixed

> X macros used appropriately and consistently
>  - %{buildroot} and $RPM_BUILD_ROOT -- pick one :)
fixed

> X consider using cp -p to preserve timestamps
fixed
> * rpmlint output when run on the binary RPMs
>   $ rpmlint ../RPMS/i386/eclipse-quickrex-3.5.0-2.fc7.i386.rpm 
>   eclipse-quickrex.i386: W: dangling-symlink
>  
>
/usr/share/eclipse/plugins/de.babe.eclipse.plugins.QuickREx_3.5.0/lib/jakarta-regexp-1.4.jar
>   /usr/share/java/regexp.jar
>   eclipse-quickrex.i386: W: symlink-should-be-relative
>  
>
/usr/share/eclipse/plugins/de.babe.eclipse.plugins.QuickREx_3.5.0/lib/jakarta-regexp-1.4.jar
>   /usr/share/java/regexp.jar
>   eclipse-quickrex.i386: W: dangling-symlink
>  
>
/usr/share/eclipse/plugins/de.babe.eclipse.plugins.QuickREx_3.5.0/lib/jakarta-oro-2.0.8.jar
>   /usr/share/java/jakarta-oro-2.0.8.jar
>   eclipse-quickrex.i386: W: symlink-should-be-relative
>  
>
/usr/share/eclipse/plugins/de.babe.eclipse.plugins.QuickREx_3.5.0/lib/jakarta-oro-2.0.8.jar
>   /usr/share/java/jakarta-oro-2.0.8.jar
> 
>  - I think these are fine and I've never been told otherwise :).
:)
> ? package should build in mock
>  - I didn't try but I don't anticipate any problems.  Alphonse, can you
>    try this?
Naturally ;-), yeah the package build nicely with mock.

I have run rpmlint on the binary package build in mock and rpmlint complain only 
about the symlinks stuffs.

Thanks for the review

 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.