[Bug 247852] Review Request: R-systemfit - Simultaneous Equation Estimation R Package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: R-systemfit -  Simultaneous Equation Estimation R Package


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247852





------- Additional Comments From tibbs at math.uh.edu  2007-07-11 21:22 EST -------
The URL seems incorrect; I think
   http://cran.r-project.org/src/contrib/Descriptions/systemfit.html
is the right one, or perhaps
   http://www.systemfit.org/

You'll need a Requires: R there as well.  (The template has been updated to
reflect that.)

rpmlint has the usual two complaints, plus one other:
W: R-systemfit file-not-utf8 /usr/share/R/library/systemfit/man/systemfit.Rd.gz
This is due to a single u-with-umlaut on line 244 of systemfit.Rd; a call to
iconv should fix it up.

The checks are very noisy, with many differences shown in the least significant
digits.  However, it looks to me as if everything comes out OK.

* source files match upstream:
   3172eda701ed559443f6e8344263e772ea11dd5401108fe61b84a324949643b5  
   systemfit_0.8-2.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently
  (follows the R example template).
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
X rpmlint has a valid complaint.
* final provides and requires are sane:
   R-systemfit = 0.8-3.fc8
  =
   /bin/sh
   R
* %check is present and all tests pass.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.