[Bug 246716] Review Request: ruby-RMagick - Graphics Processing for Ruby and Ruby on Rails

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ruby-RMagick - Graphics Processing for Ruby and Ruby on Rails


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246716





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-07-13 13:25 EST -------
(In reply to comment #2)
> *%define		rubyabi		1.8
> Is this a hardrequires or is it possible to have someting like in python:
There is surely some hack (some GLib users use the hack),
it is rather complicated (because ruby is not included in
minimum build environ) and I find the hack of little sense.
NOTE: On rawhide, the hack you mentioned can no longer be used
      even for python because python is removed from minimum
      build environ

> * why does this is needed : %define	repoid	21576 ?
This figure is needed for source URL, but I don't want to
write the figure directly on URL because this id may change
for different version.

> * Why do you have BuildRequires: ruby and ruby-devel ?
This type of BuildRequires frequently happens when BuildRequires
target rpm ship -libs package (i.e. ruby-devel requires ruby-libs
but does not require ruby itself).

> * About # 1. First hack ImageMagick font configuration
> Does this is a special tweak for RMagick or this could be 
> fixed in ImageMagick pacakge ?
This can be fixed by ImageMagick side fix, however to file a
bug against ImageMagick, I must explain and justify 
why the fix is needed against ImageMagick, and before 
it perhaps I must investigate ImageMagick code... (for now
I can only say "after this fix RMagick works, don't know
why it is needed in detail"

So for now I fixed RMagick side.

> build.log:
> * Why theses dependencies aren't found ?
> 
> checking for AdaptiveBlurImageChannel... no
> checking for AdaptiveResizeImage... no
This is because I build against ImageMagick and not against
GraphicsMagick. From googling I have a impression that
most user uses RMagick with ImageMagick.
 
> * -doc
> But do # 3. clean up is needed to prevent thoses files to be installed ? 
> Are
> they installed in $(pwd)/Trash ? Why not to use instead (for -doc)
> %doc Trash/*
Simply my custom. For documentation I don't want to use
installed files by make file because it is usually troublesome.

> * naming - I don't know if this is mandatory but -docs is sometime choosen
> instead of -doc for documentation sub-package...
lftp ftp.kddilabs.jp:/Linux/packages/fedora/development/i386/os/Fedora> ls -al
*-doc-* | wc -l
87
lftp ftp.kddilabs.jp:/Linux/packages/fedora/development/i386/os/Fedora> ls -al
*-docs-* | wc -l
33


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.