[Bug 208034] Review Request: HippoDraw - Interactive and Python scriptable data analysis application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: HippoDraw - Interactive and Python scriptable data analysis application


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208034





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-07-17 13:53 EST -------
Now mock build passed on rawhide i386.

For 1.20.8-1:

* #define macro / file name namespace issue
  - This time HippoDraw-devel contains named "version.h" and
    defines _VERSION_H_ macro
    IMO this will cause file name/define macro namespace conflict.
    Actually some package badly install header file named
    "version.h" and this will cause namespace conflict when
    both packages which use "version.h" are included.

    Would you rename this to "HippoDraw_version.h" and
    change to "ifdef _HippoDraw_version_h_" or something, or
    simply remove version.h from HippoDraw-devel?


* Again ifdef judgment
  - Again what is happening on /usr/include/HippoDraw/numarray/num_util.h?
    This package contains #ifdef HAVE_NUMPY, however we cannot 
    tell whether HAVE_NUMPY is defined or not when rebuilt 
    (please recheck the comment 43 by Hans).

    Is your comment 33 still valid? (in that case, is num_util.h really
    needed for header files?)

* Requires
  - Please remove explicit Requires when libraries' dependency automatically
    checked by rpmbuild pulls the dependency.
    For example "Requires: cfitsio" is not needed for main package
    because main package has the dependency for libcfitsio.so.0.

* Desktop file
  - fedora-HippoDraw.desktop refers to the wrong name icon.

* defattr
  For defattr, we now recommend %defattr(-,root,root,-)

* doc subpackage naming
  - Perhaps simply "HippoDraw-docs" may be better?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.