[Bug 188542] Review Request: hylafax

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hylafax


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188542





------- Additional Comments From faxguy at howardsilvan.com  2007-07-17 14:51 EST -------
Okay, here's where I'm at.  I won't post another SRPM and SPEC file just yet...
let's see if you can help me through these last rpmlint warnings/errors or if we
can agree that they're not blockers.

[root at dhcp006 SPECS]# rpmlint /usr/src/redhat/SRPMS/hylafax-5.1.6-1.src.rpm
E: hylafax configure-without-libdir-spec

HylaFAX's configure is not a direct derivative from the autoconf versions, and
thus there is no --libdir= option for HylaFAX's configure.

[root at dhcp006 SPECS]# rpmlint
/usr/src/redhat/RPMS/x86_64/hylafax-5.1.6-1.x86_64.rpm | sort
E: hylafax executable-marked-as-config-file /etc/cron.daily/hylafax
E: hylafax executable-marked-as-config-file /etc/cron.hourly/hylafax
E: hylafax executable-marked-as-config-file /etc/rc.d/init.d/hylafax

I'm not sure what to do about these, exactly.  These are all executable scripts
that are meant to be configurable by the administrator, and we don't want to
overwrite the configured script on upgrades.

E: hylafax non-readable /var/spool/hylafax/etc/hosts.hfaxd 0600

This is intentional.  Only the owner should be able to read this file.

E: hylafax non-standard-dir-perm /var/spool/hylafax/archive 0700
E: hylafax non-standard-dir-perm /var/spool/hylafax/docq 0700
E: hylafax non-standard-dir-perm /var/spool/hylafax/doneq 0700
E: hylafax non-standard-dir-perm /var/spool/hylafax/pollq 0700
E: hylafax non-standard-dir-perm /var/spool/hylafax/sendq 0700
E: hylafax non-standard-dir-perm /var/spool/hylafax/tmp 0700

Again, these are intentional.  Only the owner should be accessing these
directories.  (All activity goes through the server.  Local users don't access
these files directly.)

E: hylafax script-without-shebang /usr/sbin/faxsetup.linux

This file, faxsetup.linux, is a shell script stub.  It is included (via ".")
from the invoked faxsetup script.

W: hylafax non-conffile-in-etc /etc/hylafax/faxcover_example_sgi.ps

While it is true that the example coversheet is not itself a configuration file,
it is meant to be configured - i.e. replaced, and it belongs there.

[root at dhcp006 SPECS]# rpmlint hylafax | sort
E: hylafax executable-marked-as-config-file /etc/cron.daily/hylafax
E: hylafax executable-marked-as-config-file /etc/cron.hourly/hylafax
E: hylafax executable-marked-as-config-file /etc/rc.d/init.d/hylafax
E: hylafax non-readable /var/spool/hylafax/etc/hosts.hfaxd 0600
E: hylafax non-standard-dir-perm /var/spool/hylafax/archive 0700
E: hylafax non-standard-dir-perm /var/spool/hylafax/docq 0700
E: hylafax non-standard-dir-perm /var/spool/hylafax/doneq 0700
E: hylafax non-standard-dir-perm /var/spool/hylafax/pollq 0700
E: hylafax non-standard-dir-perm /var/spool/hylafax/sendq 0700
E: hylafax non-standard-dir-perm /var/spool/hylafax/tmp 0700
E: hylafax script-without-shebang /usr/sbin/faxsetup.linux
W: hylafax non-conffile-in-etc /etc/hylafax/faxcover_example_sgi.ps

We've covered all of these already above.

W: hylafax unused-direct-shlib-dependency /usr/lib64/libfaxserver.so.5.1.6
/lib64/libm.so.6
W: hylafax unused-direct-shlib-dependency /usr/lib64/libfaxutil.so.5.1.6
/lib64/libm.so.6

These two are particularly curious to me, and I cannot figure them out.  Here
are the corresponding build lines:

/usr/bin/g++ -shared -fpic -Wl,-soname,libfaxserver.so.5.1.6 -o
libfaxserver.so.5.1.6 \
            faxApp.o FaxItem.o FaxRequest.o FaxAcctInfo.o FaxMachineInfo.o
FaxMachineLog.o FaxPoll.o FaxRecv.o FaxSend.o ModemServer.o FaxServer.o
UUCPLock.o ServerConfig.o ClassModem.o FaxModem.o Class0.o Class1.o Class10.o
Class1Ersatz.o Class1Poll.o Class1Recv.o Class1Send.o Class2.o Class20.o
Class21.o Class2Ersatz.o Class2Poll.o Class2Recv.o Class2Send.o CopyQuality.o
G3Decoder.o G3Encoder.o MemoryDecoder.o HDLCFrame.o ModemConfig.o NSF.o
FaxFont.o PCFFont.o TagLine.o  ../util/libfaxutil.so.5.1.6  -ltiff

/usr/bin/g++ -shared -fpic -Wl,-soname,libfaxutil.so.5.1.6 -o
libfaxutil.so.5.1.6 Array.o BoolArray.o Dictionary.o Obj.o PageSize.o RE.o
REArray.o REDict.o StackBuffer.o Str.o StrArray.o StrDict.o Dispatcher.o
IOHandler.o Sys.o SystemLog.o Timeout.o Fatal.o AtSyntax.o DialRules.o FmtTime.o
Sequence.o TimeOfDay.o FaxDB.o TextFormat.o Class2Params.o FaxParams.o
FaxClient.o FaxConfig.o FaxRecvInfo.o FaxSendInfo.o JobExt.o CallID.o ModemExt.o
SendFaxJob.o SendFaxClient.o TypeRules.o Transport.o InetTransport.o
UnixTransport.o SNPPClient.o SNPPJob.o cvtfacility.o fxassert.o \
             -ltiff  -lz  -L../regex -lregex

Please notice that -lm is not being used here as the rpmlint warning message
seems to indicate.  Now, -lm is used elsewhere in the build, but not for these
DSOs, but even if I remove the -lm from everywhere in the build (it seems
unnecessary) this rpmlint warning still occurs.  The header file math.h is
included in a few source files, but not in any source file that is used to build
libfaxutil.  So something is very confusing to me here.  Any insight would be
appreciated.

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.