[Bug 230344] Review Request: bacula - Cross platform network backup for Linux, Unix, Mac and Windows.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bacula - Cross platform network backup for Linux, Unix, Mac and Windows.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230344





------- Additional Comments From andreas at bawue.net  2007-07-18 16:18 EST -------
(In reply to comment #42)

> ok still alot of rpmlint noise.  permissions are ok 

The noise is basically the following line:
"W: bacula unversioned-explicit-provides bacula-director-%{version}-%{release}"
Looks like an ignorable problem with rpmlint as it does no variable expansion.


> config files should be noreplace 

Most of the config files are marked as noreplace.
I did leave it out for security relevant files such as /etc/pam.d/gnome-console
in order to be able to fix problems with a package update and make sure they are
applied and not put into a .rpmnew file.
Do we have a policy on that?

Same goes for the logwatch files:
W: bacula-director-common conffile-without-noreplace-flag
/etc/logwatch/conf/logfiles/bacula.conf
W: bacula-director-common conffile-without-noreplace-flag
/etc/logwatch/conf/services/bacula.conf

The logformat does change from time to time. That way we can update the definitions.

> initscripts really should have incoherent warnings fixed 

W: bacula-client incoherent-subsys /etc/rc.d/init.d/bacula-fd $prog
The executable is stored in a variable.
rpmlint -i gives "It is also possible that rpmlint gets this wrong, especially
if the init script contains nontrivial shell variables and/or assignments. These
cases usually manifest themselves when rpmlint reports that the subsys name
starts a with '$'; in these cases a warning instead of an error is reported and
you should check the script manually."

If that's important one could change the initscripts.

About the incoherent names: This might not be that easy. We could change the
names from the upstream used bacula-fd, -sd and -dir, to bacula-client,
bacula-storage and bacula-director, which would conform to the bacula package
names. This would however not remove the rpmlint warnings as the real package
names are bacula-{director,storage}-{mysql,sqlite,postgresql} and the init
script is packaged in the -common file getting its runtime information from the
alternatives subsystem.

Either way, the warning won't go away. However, I'm open to renaming the
initscripts to conform to the package names although the current names are what
upstream has been using in the past.
 
> E: bacula-common wrong-script-interpreter
> /usr/share/doc/bacula-common-2.0.3/examples/afs-bacula "/usr/afsws/bin/pagsh"
> 
> make this non executable

It actually is.
-rw-r--r--  /usr/share/doc/bacula-common-2.0.3/examples/afs-bacula
rpmlint issue, ignoring.


> %if 0%{?fedora}
>         %if "%{fedora}" >= "7"
> BuildRequires: tcp_wrappers-devel
>         %else
> BuildRequires: tcp_wrappers
>         %endif
> %endif
> 
> should really be 
> %if "%{?fedora}" >= "7"
> BuildRequires: tcp_wrappers-devel
> %else
> BuildRequires: tcp_wrappers
> %endif
> 
> since im sure we will want tcp_wrappers for epel.

Right. 
 
> nothing owns /etc/bacula/  or /usr/libexec/bacula/

Thx.

Try -7 at http://home.bawue.de/~ixs/bacula/bacula-2.0.3-7.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.