[Bug 242543] Review Request: AcetoneISO - CD/DVD Image Manipulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: AcetoneISO - CD/DVD Image Manipulator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242543


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora

dan at danny.cz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From dan at danny.cz  2007-07-18 16:43 EST -------
First sorry for this delay, but the review is here:

OK	source files doesn't match upstream, because non-distributable/non-free
	    file (poweriso) is removed, but the rest was checked to be the same
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible (GPL) and license text is included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (Development/i386) and native FC6/x86_64
OK	debuginfo package looks complete.
OK	rpmlint output can be ignored
OK	final provides and requires look sane:
OK	no shared libraries are added to the regular linker search paths.
BAD	doesn't own the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	no scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	is a GUI app and the desktop file is properly installed


BAD	doesn't own the directories it creates.
	    AcetoneISO.kmdr is placed into %{_datadir}/apps/%{name}/scripts,
	    but the directory %{_datadir}/apps/%{name} is unowned


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.