[Bug 248857] Review Request: schedtool - A tool to query or alter process scheduling policy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: schedtool - A tool to query or alter process scheduling policy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248857





------- Additional Comments From wolfy at nobugconsulting.ro  2007-07-19 07:29 EST -------
Quick glance at http://tgmweb.at/gadllah/schedtool-1.2.9-3.fc7.src.rpm

- the rpm_opt_flags problem is still there:
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.28294
+ umask 022
+ cd /builddir/build/BUILD
+ cd schedtool-1.2.9
+ LANG=C
+ export LANG
+ unset DISPLAY
+ make
make CFLAGS="-Os -fomit-frame-pointer -s -pipe -DHAVE_AFFINITY" schedtool
make[1]: Entering directory `/builddir/build/BUILD/schedtool-1.2.9'
gcc -Os -fomit-frame-pointer -s -pipe -DHAVE_AFFINITY   -c -o schedtool.o
schedtool.c
schedtool.c: In function 'set_process':
schedtool.c:450: warning: pointer/integer type mismatch in conditional expression
gcc -Os -fomit-frame-pointer -s -pipe -DHAVE_AFFINITY   -c -o error.o error.c
gcc   schedtool.o error.o   -o schedtool
make[1]: Leaving directory `/builddir/build/BUILD/schedtool-1.2.9'
+ exit 0
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.28294
+ umask 022
+ cd /builddir/build/BUILD
+ cd schedtool-1.2.9
+ LANG=C
+ export LANG
+ unset DISPLAY
+ rm -rf /var/tmp/schedtool-1.2.9-3.fc7-root-mockbuild
+ make install 'CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic' D
ESTPREFIX=/usr DESTDIR=/var/tmp/schedtool-1.2.9-3.fc7-root-mockbuild
make CFLAGS="-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -DHAVE_AFFIN
ITY" schedtool
make[1]: Entering directory `/builddir/build/BUILD/schedtool-1.2.9'
make[1]: `schedtool' is up to date.

solution: you have to pass the RPM_OPT_FLAGS flag at build time, not at install

- the timestamp of the files is not preserved. you'd better revert to %doc and
remove the docdir line
- schedtool-debuginfo is empty


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.