[Bug 248778] Review Request: gtkperf - Test GTK+ performance

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtkperf - Test GTK+ performance


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248778


adel.gadllah at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adel.gadllah at gmail.com




------- Additional Comments From adel.gadllah at gmail.com  2007-07-19 15:01 EST -------
here is a unofficial/incomplete review (I am not sponsored yet):

MUST items:

MUST: rpmlint must be run on every package.
-> ok (no output)

MUST: The package must be named according to the Package Naming Guidelines.
-> ok

MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption on  Package Naming Guidelines. 
->ok

MUST: The package must be licensed with an open-source compatible license and
meet other legal requirements as defined in the legal section of Packaging
Guidelines.
->ok

MUST: The package must be licensed with an open-source compatible license and
meet other legal requirements as defined in the legal section of Packaging
Guidelines.
->ok

MUST: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
-> NOT ok; please package COPYING

MUST: The spec file must be written in American English.
->ok

MUST: The spec file for the package MUST be legible. 
-> ok

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. 
-> ok (4331dde4bb83865e15482885fcb0cc53)

MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture.
->ok (tested on F7 x86_64)


MUST: A package must own all directories that it creates. 
->ok

MUST: Packages must not own files or directories already owned by other packages.
->ok

MUST: All filenames in rpm packages must be valid UTF-8.
->ok

MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT)
->ok

MUST: If a package includes something as %doc, it must not affect the runtime of
the application.
->ok

MUST: Large documentation files should go in a -doc subpackage. 
->ok (no large documentation)

MUST: If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation of
that specific package. Without this, use of Prefix: /usr is considered a blocker.
->ok (not relocatable)

MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel package.
->ok (no libs in this package)

MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} 
->ok (no devel package)

MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section.
->NOT ok (no desktop file found!)


MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
->ok

MUST: Header files must be in a -devel package.
->ok (no header files)

MUST: Static libraries must be in a -static package.
->ok (no static libs;no libs at all)

MUST: The package must contain code, or permissable content.
->ok

MUST: The package must meet the  Packaging Guidelines.
->NOT ok, (no desktop file, license file not installed)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.