[Bug 248457] Review Request: perl-Devel-Profiler - Perl profiler compatible with dprofpp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Devel-Profiler - Perl profiler compatible with dprofpp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248457


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-07-20 23:29 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
c52d615e3083defd2c71726f21b2127a  Devel-Profiler-0.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/01basic.........ok
t/02die...........ok
t/03goto..........main::goto_bar has 1 unstacked calls in outer
main::bar has -1 unstacked calls in outer
ok
t/04crash.........ok
t/05packages......ok
t/06caller........ok
t/07constants.....ok
t/08fork..........ok
t/09fcntl.........ok
t/10autoload......ok
        6/6 skipped: profiling AUTOLOAD not working yet
t/11sub_filter....ok
All tests successful, 6 subtests skipped.
Files=11, Tests=56,  8 wallclock secs ( 3.40 cusr +  1.19 csys =  4.59 CPU)
+ exit 0
+Provides: perl(Devel::Profiler) = 0.04 perl(Devel::Profiler::Apache) = 0.01
perl(Devel::Profiler::Test) = 0.01
+Requires: perl >= 0:5.006 perl(:MODULE_COMPAT_5.8.8) perl(B) perl(Exporter)
perl(File::Path) perl(Test::More) perl(Time::HiRes) perl(constant) perl(strict)
perl(warnings)
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.