[Bug 241588] qfaxreader - a monochrome/color multipage .TIFF files visualisation utility designed for viewing faxes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: qfaxreader - a monochrome/color multipage .TIFF files visualisation utility designed for viewing faxes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241588





------- Additional Comments From adel.gadllah at gmail.com  2007-07-23 11:41 EST -------
Package Review:
==================================================
----------------------------------
MUST: rpmlint must be run on every package.
----------------------------------
OK, no output.
----------------------------------
MUST: The package must be named according to the Package Naming Guidelines.
----------------------------------
OK
----------------------------------
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec 
----------------------------------
OK
----------------------------------
MUST: The package must meet the  Packaging Guidelines.
----------------------------------
NOT OK!
Please replace /usr/bin in %files with %{_bindir}
----------------------------------
MUST: The package must be licensed with an open-source compatible license and
meet other legal requirements.
----------------------------------
OK
----------------------------------
MUST: The License field in the package spec file must match the actual license.
----------------------------------
OK (GPL)
----------------------------------
MUST: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, 
containing the text of the license(s) for the package must be included in %doc.
----------------------------------
OK
----------------------------------
MUST: The spec file must be written in American English.
----------------------------------
OK
----------------------------------
MUST: The spec file for the package MUST be legible.
----------------------------------
OK
----------------------------------
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
----------------------------------
OK (mdsum = 165774433c44f721e82552c866e7be87)
----------------------------------
MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture.
----------------------------------
OK (Tested on F7 x86_64)
----------------------------------
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in ExcludeArch.
----------------------------------
N/A
----------------------------------
MUST: All build dependencies must be listed in BuildRequires.
----------------------------------
OK
----------------------------------
MUST: If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation of
that specific package.
----------------------------------
OK (not relocateable)
----------------------------------
MUST: A package must own all directories that it creates.
----------------------------------
OK
----------------------------------
MUST: A package must not contain any duplicate files in the %files listing.
----------------------------------
OK
----------------------------------
MUST: Permissions on files must be set properly.
----------------------------------
OK
----------------------------------
MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
----------------------------------
OK
----------------------------------
MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines. 
----------------------------------
NOT OK!
Please replace /usr/bin in %files with %{_bindir}
----------------------------------
MUST: The package must contain code, or permissable content. 
----------------------------------
OK
----------------------------------
MUST: If a package includes something as %doc, it must not affect the runtime of
the application.
----------------------------------
OK
----------------------------------
MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section.
----------------------------------
OK
----------------------------------
MUST: Packages must not own files or directories already owned by other packages. 
----------------------------------
OK
----------------------------------
MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
----------------------------------
OK
----------------------------------
MUST: All filenames in rpm packages must be valid UTF-8.
----------------------------------
SHOULD: The reviewer should test that the package builds in mock.
----------------------------------
OK (builds fine on F7 x86_64)
----------------------------------
SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.
----------------------------------
OK
----------------------------------
==================================================
Summary:
Package looks ok, one blocker:
Please replace /usr/bin in %files with %{_bindir}
==================================================

When you fix this blocker I will approve it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.