[Bug 249296] Review Request: libgeotiff - GeoTIFF format handler library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgeotiff - GeoTIFF format handler library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249296





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-07-23 15:06 EST -------
Created an attachment (id=159804)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=159804&action=view)
mock build log of libgeotiff 1.2.4-0.1.rc1 on rawhide i386

Very rapid comment because I want to go to bed..

* debuginfo rpm is of no use. It seems that -g option is
  removed.
* I suggest to move the header files to the subdirectory of /usr/include
  and hide them from /usr/include (as you wrote on .pc file)
* Specify the full URL of the source.
* I may be wrong, however (for example)
  /usr/include/geonames.h contains
--------------------------------------------
    47	static KeyInfo _keyInfo[] =  {
    48	#   include "geokeys.inc"   /* geokey database */
    49	    END_LIST
--------------------------------------------
  but geokeys.inc is missing?
* /usr/include/xtiffio.h contains
--------------------------------------------
    10	#include "tiffio.h"
--------------------------------------------
  And it seems that tiffio.h is included in libtiff-devel.
  So libgeotiff-devel should require libtiff-devel.
* Check if
--------------------------------------------
make install DESTDIR=<foo> INSTALL="%{__install} -p"
--------------------------------------------
  works to keep timestamps on the header files installed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.