[Bug 249325] Review Request: yum-updatesd - Update notification daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yum-updatesd - Update notification daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249325


jbowes at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From jbowes at redhat.com  2007-07-23 15:25 EST -------
I have 4 minor nits:
* use BuildArch instead of BuildArchitectures
* use the 4 argument form of defattr
* include a full url for source0 (when such a thing exists)
* use sh rather than bash for the init script (if possible)

These are just my preferences, however.

Review:
* source files match upstream:
   Jeremy is the upstream, so this is ok.   
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (F7, i686).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   config(yum-updatesd) = 1:0.3-1.fc7
   yum-updatesd = 1:0.3-1.fc7
  =
   /bin/bash  
   /bin/sh  
   /sbin/chkconfig  
   /sbin/service  
   /usr/bin/python  
   config(yum-updatesd) = 1:0.3-1.fc7
   dbus-python  
   gamin-python  
   pygobject2  
   python >= 2.4
   yum >= 3.2.0
* %check is not present (no test suite upstream)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriplets are sane.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.