[Bug 248410] Review Request: perl-Params-CallbackRequest - Functional and object-oriented callback architecture

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Params-CallbackRequest - Functional and object-oriented callback architecture


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248410


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-07-24 21:51 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
9db73e6e2f39cd4648ada030013414e7  Params-CallbackRequest-1.17.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
t/01basic.............ok
t/02priority..........ok
t/03keys..............ok
t/04errors............ok
t/05object............ok
t/06object_request....ok
t/07combined..........ok
t/08apache............skipped
        all skipped: Testing of apache_req requires Apache::FakeRequest
t/09pod...............ok
All tests successful, 1 test skipped.
Files=9, Tests=421,  1 wallclock secs ( 0.76 cusr +  0.10 csys =  0.86 CPU)
+Provides: perl(Params::Callback) = 1.17 perl(Params::CallbackRequest) = 1.17
perl(Params::CallbackRequest::Exceptions) = 1.17
+Requires: perl(:MODULE_COMPAT_5.8.8) perl(Exception::Class)
perl(Exception::Class) >= 1.10 perl(Params::CallbackRequest::Exceptions)
perl(Params::Validate) perl(Params::Validate) >= 0.59 perl(constant)
perl(strict) perl(vars)

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.