[Bug 239385] Review Request: peless - Text Browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: peless - Text Browser


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239385





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-07-26 14:08 EST -------
* Do CFLAGS, CXXFLAGS, PKG_CONFIG_PATH need to be set explicitly?

  %configure sets CFLAGS, CXXFLAGS (please check what %configure
  does by 'rpm --eval %configure') and pkg-config automatically
  searched %_libdir/pkgconfig and no .pc files must be installed
  under %_datadir/pkgconfig.

* desktop file should be installed by using desktop-file-install
  (in desktop-file-utils)

* Now we recommend %defattr(-,root,root,-)

* Please use macros. /usr should be replaced with %_prefix 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.