[Bug 249725] Review Request: bombardier - The GNU bombing utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bombardier - The GNU bombing utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249725





------- Additional Comments From wart at kobold.org  2007-07-26 17:57 EST -------
* The 'Version' field in the desktop file refers to the .desktop file
  specification version, not the application version.  Should be '1.0'.

* Use the %{_mandir} macro for the man page directory.  You also don't
  need to compress it yourself; rpm will do that for you:

install -pD -m 644 bombardier.6 %{buildroot}%{_mandir}/man6/bombardier.6

* RPM_OPT_FLAGS is still not being used on the compile line.  You can
  add a single colon in the Makefile to get it to pick up CFLAGS from the
  command line:

Makefile:
  CFLAGS:=-Wall -g -Werror -O2

...and in %build:
make CFLAGS="$RPM_OPT_FLAGS"


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.