[Bug 240655] Review Request: ocaml-extlib - OCaml ExtLib additions to the standard library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-extlib - OCaml ExtLib additions to the standard library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240655





------- Additional Comments From lxtnow at gmail.com  2007-07-26 23:14 EST -------
=== REQUIRED ITEMS ===

 [ OK ] Package is named according to the Package Naming Guidelines.
 [ OK ] Spec file name must match the base package.
 [ OK ] Package meets the Packaging Guidelines.
 [ FAILED ] Package successfully to build into binary rpms on at least one
        supported architecture.
 [ CHECK ] Tested on: Mock x86_64 [FC-devel]

 [ OK ] Package is not relocatable.
 [ OK ] Buildroot is correct
 [ OK ] Package is licensed with an open-source compatible license.
 [ OK ] License field in the package spec file matches the actual license.
 [ OK ] License type: LGPL
 [ OK ] The source package includes the text of the license(s).
 [ OK ] Spec file is legible and written in American English.
 [ SKIP ] Package is not known to require ExcludeArch.
 [ OK ] All build dependencies are listed in BuildRequires.
 [ OK ] The spec file handles locales properly.
 [ SKIP ] ldconfig called in %post and %postun if required.
 [ Ok ] Package must own all directories that it creates.
 [ OK ] Package requires other packages for directories it uses.
 [ OK ] Package does not contain duplicates in %files.
 [ OK ] Permissions on files are set properly.
 [ OK ] Package has a %clean section.
 [ OK ] Package consistently uses macros.
 [ OK ] Package contains code, or permissable content.
 [ SKIP ] Large documentation files are in a -doc subpackage, if required.
 [ CHECK ] Package uses nothing in %doc for runtime.
 [ SKIP] Header files in -devel subpackage, if present.
 [ SKIP ] Static libraries in -devel subpackage, if present.
 [ SKIP ] Package requires pkgconfig, if .pc files are present.
 [ SKIP ] Development .so files in -devel subpackage, if present.
 [ CHECK ] Fully versioned dependency in subpackages, if present.
 [ OK ] Package does not contain any libtool archives (.la).
 [ SKIP ] Package contains a properly installed %{name}.desktop file.
 [ OK ] Package does not own files or directories owned by other packages.

According to OCaml Packaging Guideline:
 
 [ OK ] OCaml modules / libs should be named ocaml-foo.
 [ OK ] The spec file should still build bytecode libraries and binaries.
 [ OK ] Should Test if the native compiler is present.
 [ OK ] main package should contain files matching all files which're mentioned    
        in OCaml guideline if present.
 [ OK ] -devel sub-package Should contains all files which're mentioned in OCaml
       guidelines if present.


=== Issues ===

# Mock

Mock fails on : 
--------------------------------------------------------------
[...]
sh: ocamldoc: command not found
Exit Code 127 - Stopped
error: Bad exit status from /var/tmp/rpm-tmp.54888 (%install)
--------------------------------------------------------------
Which mean that ocmal-ocamldoc is missing as BR.
Just add it.


# some comment about __docdir

you don't need to past doc files to __docdir/%{name}-%{version}-devel in %files
devel
%doc already do this job ;-).
just add your subdirectory to %doc like this:
%doc extlib-doc/*

Of course, thats imply to re-manage your "# Move the HTML documentation
somewhere sensible."
by then, you should just  have something like this:
--------------------------------------------------
# Move the HTML documentation somewhere sensible.
mkdir extlib-doc
mv $extlibdir/extlib-doc extlib-doc
--------------------------------------------------





-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.