[Bug 245015] PolicyKit package review

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: PolicyKit package review


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245015





------- Additional Comments From davidz at redhat.com  2007-07-27 12:26 EST -------
(In reply to comment #6)
> Some of the earlier comments still apply:
> 
> - Shouldn't have to BR both dbus-glib-devel and dbus-glib. Isn't one requiring
>   the other anyway ?

Fixed.

> - -devel package needs to require pkgconfig 

Fixed.

> - -docs package needs to require gtk-doc

Fixed (with a vengeful comment).

> - must require pam, for /etc/pam.d

Fixed.

> - must own /etc/PolicyKit, /usr/lib/PolicyKit, /usr/lib/PolicyKit/modules

Fixed. The latter does not exist anymore FWIW.

> - %post and %postun should just do -p /sbin/ldconfig if thats all they do

Gee. Fixed, anyway.

> - The errors about permissions should probably be handled
>   by adding a comment explaining why these permissions are necessary

I've added a comment that this is explained in the upstream design docs.

Will attach new spec file.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.