[Bug 247417] Review Request: bouml - UML2 tool box to specify and generate code

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bouml - UML2 tool box to specify and generate code


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247417





------- Additional Comments From debarshi.ray at gmail.com  2007-07-28 08:48 EST -------
(In reply to comment #19)

> I see that you already have a reviewer, so your request for one to the
> mailinglist is a bit strange.

That happened only after I posted on the list. :-)

> Must FIX
> ----------
> * use %{_libdir} for arch specific files, you can do this by invoking make as
>   follows in %build:
>   make %{?_smp_mflags} BOUML_LIB=%{_libdir}/%{name}
>   and like this in %install:
>   make install DESTDIR=$RPM_BUILD_ROOT BOUML_LIB=%{_libdir}/%{name}

Fixed.

> * the .desktop files do not contain mimetypes, so there is no reason to run
>   update-desktop-database in %post[un]

Fixed.

> * the %post[un] icon-cache scriptlets are wrong, the touch line misses || :

Fixed. I don't see it at
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets -- maybe the Wiki
needs to be updated.

>   and the gtk-update-icon-cache line must only be executed if 
>   gtk-update-icon-cache is present, see:
>
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda

Fixed. I had taken the snippet from that page itself, but seems that the page
has been updated since. :-)

> * Add: "Requires: hicolor-icon-theme" for /usr/share/icons/hicolor/*/* dirs
>   ownership

Fixed.

> Should FIX
> ----------
> The CFLAGS are not really an issue as bouml uses qmake to generate the makefile
> and qmake puts the right flags into the generated makefiles itself. However to
> be _really_ sure the right flags get used, for example when RPM_OPT_FLAGS get
> changed (qmake uses RPM_OPT_FLAGS as defined when it was build), use the
> following in %build:
> make %{?_smp_mflags} BOUML_LIB=%{_libdir}/%{name} CFLAGS="$RPM_OPT_FLAGS" \
>   CXXFLAGS="$RPM_OPT_FLAGS"

Fixed.

Spec: http://rishi.fedorapeople.org/bouml-3.spec

I shall upload the SRPM once I finish building it, which takes quite some time. :-)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.