[Bug 248231] Review Request: ustr - String library, very low memory overhead, simple to import

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ustr - String library, very low memory overhead, simple to import


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248231





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-07-29 12:37 EST -------
Well, now ustr is rebuilt on all archs as:
http://koji.fedoraproject.org/koji/taskinfo?taskID=80889


Then for -0.6:

> * Still fedora specific compilation flags are not honored (partially).
>  On what?
>  The unit tests?
  - Oh, yes, for tests. Perhaps this can be ignored.

* File entry
  - I just noticed that: 
-------------------------------------------------
$ rpm -qlp ustr-*rpm | sort | uniq -d
/usr/include/ustr-conf-debug.h
/usr/include/ustr-debug.h
-------------------------------------------------
   ? Perhaps it is better that all header files are
     hidden under /usr/include/ustr.

* Compilation flags
  ? On compiling debugging source code:
-------------------------------------------------
Compiling for A DBG lib: ustr-io-dbg-code.c
cc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -W -Wall -Wundef -Wshadow -Wpointer-arith
-Wbad-function-cast -Wcast-align -Wwrite-strings -Waggregate-return
-Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs
-Wno-format-zero-length -Wformat-nonliteral -Wformat-security  -O1 -ggdb3      
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -o ustr-cmp-code-a-dbg.o -c
ustr-cmp-dbg-code.c
-------------------------------------------------
    the fedora compilation flags (-O2) is overwritten
    by -O1. Is this intentional?

* File name
  ? Well, it is okay, however would you rename the file
    which contains white space in its name?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.