[Bug 247984] Review Request: Etoys - Squeak-based learning environment for OLPC

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Etoys - Squeak-based learning environment for OLPC


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247984





------- Additional Comments From tibbs at math.uh.edu  2007-07-29 14:47 EST -------
Just a few comments; I can't build this because the dependency isn't in, but I
slanced over the spec file.

Don't use Prefix: or Vendor:.

http://www.squeakland.org/ looks to be a better URL.

There's no need for the
  [ -n "%{buildroot}" -a "%{buildroot}" != "/" ] && rm -rf "%{buildroot}"
magic. You set the buildroot in the spec; it won't be '/'.

It's not really necessary to include the full upstream changelog as your
changelog, although it's OK if that's what you want to do.

The unversioned doc directory is odd.  Most packages use %doc to mark
documentation in the source directory; rpm will copy it into a versioned
directory under /usr/share/doc.  I'm honestly not sure if an unversioned
documentation directory is OK.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.