[Bug 249929] Review Request: dynagen - Dynamips Hypervisor Client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dynagen - Dynamips Hypervisor Client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249929





------- Additional Comments From dev at nigelj.com  2007-07-31 04:49 EST -------
(In reply to comment #1)
> Hi
> This is my first review so I will do my best but I might need help :-)
> At a first look:
>  you should use install rather than cp to install the files

As there is no make, it doesn't _really_ matter, and there isn't really any 
advantages either way that I'm aware of (although I'll most likely change it 
later on).

>  you can change %{_mandir}/man1/dynagen.1.gz by %{name}.1.gz

I won't do this, as it breaks the logical layout of the files section, (i.e. by 
removing all the context), plus it's not consistent with other packages 
(nothing personal, just a style thing).

>  I am surprise by your %{_bindir}/* in the %files section

As there isn't a make install (where by the contents of bindir may change 
without warning), and instead I'm explicatly copying the two executable 
scripts, it's not too much of an issue in comparison to other packages, I will 
look at changing if there is anything major wrong.

> I will have a further look later on.

Please look at bug 246150 (dynamips which dynagen depends on) before reviewing 
this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.